Opened 8 years ago

Closed 8 years ago

#8321 closed Bug (fixed)

[Regression] Enter key doesn't keep inline styles

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.2
Component: UI : Enter Key Version: 3.6.2
Keywords: Regression IBM Cc: satya_minnekanti@…

Description

  1. Load the editor with the following content and selection:
    <p><strong>foo^</strong></p>
    
  2. Press enter key at the cursor position;
  3. Try type more text at the new paragraph.
  • Actual: Cursor inserted texts are not in bold.

Attachments (3)

8321.patch (653 bytes) - added by Garry Yao 8 years ago.
8321_2.patch (553 bytes) - added by Garry Yao 8 years ago.
8321_3.patch (1.9 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (17)

comment:1 Changed 8 years ago by Garry Yao

Keywords: Firefox Webkit added
Status: newconfirmed

Changed 8 years ago by Garry Yao

Attachment: 8321.patch added

comment:2 Changed 8 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

comment:3 Changed 8 years ago by Satya Minnekanti

Cc: satya_minnekanti@… added

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

The following patch fails after patch:
http://ckeditor.t/dt/core/dom/element.html

comment:5 in reply to:  1 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Firefox Webkit removed

Replying to garry.yao:

Regression of [7242], broken dt: http://ckeditor.t/dt/plugins/enter/blockquote.html

Test broken on IE as well.

comment:6 Changed 8 years ago by Frederico Caldeira Knabben

Regression failures moved out of ckeditor-tests master to t/8321
http://ckeditor.t/dt/plugins/enter/blockquote.html

comment:7 Changed 8 years ago by Frederico Caldeira Knabben

Basic test added to t/8321:
http://ckeditor.t/tt/8321/1.html

comment:8 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Regression added

comment:9 Changed 8 years ago by Garry Yao

Status: review_failedreview

Changed 8 years ago by Garry Yao

Attachment: 8321_2.patch added

comment:10 Changed 8 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

I've updated the tests and these are still failing after patch:
http://ckeditor.t/dt/plugins/enter/blockquote.html
http://ckeditor.t/tt/8321/1.html

comment:11 Changed 8 years ago by Satya Minnekanti

Keywords: IBM added

Changed 8 years ago by Garry Yao

Attachment: 8321_3.patch added

comment:12 Changed 8 years ago by Garry Yao

Status: review_failedreview

comment:13 Changed 8 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:14 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [7249].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy