Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#8407 closed Bug (fixed)

aria-setsize and aria-posinset incorrectly set on Styles drop-down

Reported by: Damian Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.6.3
Component: Accessibility Version: 3.2
Keywords: IBM Cc: Satya Minnekanti, Teresa Monahan

Description

The items in the Styles drop-down do not have their correct aria-setsize and aria-posinset attributes set.

For example, when the selection is on a default paragraph and the Styles drop-down is displayed, the first item in the list has:
aria-posinset=5 and aria-setsize=21

These values should be:
aria-posinset=1 and aria-setsize=17

Attachments (1)

8407.patch (1.1 KB) - added by Garry Yao 5 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by Jakub Ś

Status: newpending

But this set has 4 extra elements like "Image on the right" or "Borderless Table".

Yes they don't quite fit if you look that set has mainly elements from styles dropdown but is it causing any problems?

comment:2 Changed 6 years ago by Damian

@j.swiderski The extra elements you mention are present in the DOM but not displayed in the list. The problem for screen reader users is that when entering the list and focusing on the first element, the screen reader will read "option 5 of 21" when in fact, it is option 1 of 17, because the other elements are hidden and not reachable. This gives the wrong impression that there are available options in the list before the first element.

Each time the list is displayed these attributes need to update to reflect the actual state of the list.

Although, the way that the combo is implemented, aria-posinset and aria-setsize might not be required at all. The list of options does not dynamically change its contents as the user navigates it and all available options are rendered at once. See the WAI-ARIA spec for further details: http://www.w3.org/TR/wai-aria/states_and_properties#aria-posinset and http://www.w3.org/TR/wai-aria/states_and_properties#aria-setsize.

comment:3 Changed 6 years ago by Jakub Ś

Status: pendingconfirmed
Version: 3.2

Didn't pay attention to that "5 of 21" when testing. Sorry.

Reproducible from CKEditor 3.2

Changed 5 years ago by Garry Yao

Attachment: 8407.patch added

comment:4 Changed 5 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

These two attributes are presented for guiding JAWS on old IEs, since not usable right now, let's see if screen reader behaviors well without it.

comment:5 Changed 5 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.6.3
Status: reviewreview_passed

Ok, it makes sense.

comment:6 Changed 5 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed

Fixed with [7367].

comment:7 Changed 5 years ago by Garry Yao

The same change is missed on the color panel, post fixed with [7443].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy