#8413 closed Bug (fixed)
Link editor freezes when comments exists between tables
Reported by: | bmohrct | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6.3 |
Component: | Core : Styles | Version: | 3.5.1 |
Keywords: | Cc: | bmohr@… |
Description (last modified by )
This bug was reported as fixed in ticket #8232 but I am able to replicate the fix. The style/plugin.js file does not exist in my /plugins/style dir. I have however been able to better narrow down the issue. It is not an option for me to delete comments since this fix applies to many preexisting files.
I replicated the issue in the ckeditor demo by creating two tables with a HTML comment between each table. Then added text to a cell after the comment and tried to make it a link. The link editor freezes. The following HTML will create the same error:
<table> <tbody> <tr> <td> </td> <td> </td> </tr> </tbody> </table> <!-- TEST COMMENT --> <table> <tbody> <tr> <td> asdf</td> <td> </td> </tr> </tbody> </table> <p> </p>
The result adds span tags around the text and does not create a link.
This was replicated FF on OSX.
Attachments (1)
Change History (10)
comment:1 Changed 9 years ago by
Description: | modified (diff) |
---|---|
Status: | new → confirmed |
Version: | 3.6.1 → 3.5.1 |
comment:2 Changed 9 years ago by
Are there any updates or ETA for this bug? It is currently preventing up from migrating to ckeditor.
comment:3 Changed 9 years ago by
I have confirmed that this issue still occure in 3.6.2. Is there any plan to address this in the near future. It has prevented up from upgrading.
Changed 9 years ago by
Attachment: | 8413.patch added |
---|
comment:4 Changed 9 years ago by
Component: | General → Core : Styles |
---|---|
Milestone: | → CKEditor 3.6.3 |
Owner: | set to Garry Yao |
Status: | confirmed → review |
Target to milestone because of the bug severity.
comment:5 Changed 9 years ago by
@bmohrct - could you perhaps test the patch provided by @garry.yao and see if it works?
comment:6 Changed 9 years ago by
Status: | review → review_passed |
---|
comment:7 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [7372].
comment:8 Changed 9 years ago by
Just a note, that the constructor
variable used in the patch for node.js is not accepted by Rhino (org.mozilla.javascript.Parser). The returned error is "identifier is a reserved word" - the variable name must be changed into anything else.
Issue is reproducible in all browsers from CKEditor 3.0.
Message: sibling.is is not a function.
Line: 1032
URI: /3.6.2/ckeditor/_source/core/dom/range.js