Opened 8 years ago

Last modified 8 years ago

#8426 confirmed Bug

Strings for specialchar plugin added directly to editor.lang instead of editor.lang.specialChar

Reported by: Teresa Monahan Owned by:
Priority: Normal Milestone:
Component: General Version: 3.5.3
Keywords: IBM Cc: Damian, Satya Minnekanti

Description

The strings for the special characters dialog are available directly on the editor.lang object when the editor is loaded in a new language. They should be inside the editor.lang.specialChar object.

To Reproduce:

  1. Add the attached fr.js (pseudo translation file) to the specialchar/lang directory and change the value of availableLangs in specialchar\plugin.js to:
availableLangs : { en:1, fr:1 },
  1. Open ui_languages.html in a browser.
  2. Click into the editor and open the special characters dialog. Close the dialog.
  3. Inspect the editor.lang object in the DOM. editor.lang.specialChar will contain all the strings for the specialchar plugin.
  4. Now change the language to French and inspect the editor.lang object in the DOM again.

Problem: All the strings for the specialchars plugin are now available directly on the editor.lang object. Note that these are the strings in English. When the special characters dialog is opened again, the editor.lang.specialChar object is correctly updated with the pseudo French strings.

specialchar\plugin.js does extend the editor.lang.specialChar object with the string values.

CKEDITOR.tools.extend( editor.lang.specialChar, plugin.langEntries[ langCode ] );

However the CKEDITOR.plugins.load function in core\editor.js always extends the editor.lang object.

CKEDITOR.tools.extend( editor.lang, plugin.langEntries[ lang ] );

This works correctly for the a11yhelp plugin because the strings in a11yhelp\lang\xx.js are specified within the accessibilityHelp group. Perhaps the special characters lang files also need to group the strings like this?

Attachments (1)

fr.js (5.6 KB) - added by Teresa Monahan 8 years ago.

Download all attachments as: .zip

Change History (2)

Changed 8 years ago by Teresa Monahan

Attachment: fr.js added

comment:1 Changed 8 years ago by Jakub Ś

Status: newconfirmed
Version: 3.6.23.5.3

Issue has been reproducible form CKEditor 3.5.3.

Before 3.5.5 version, this TC caused error:
Message: array.indexOf is not a function
Line: 522
URI: /3.5/ckeditor/_source/core/tools.js

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy