Opened 6 years ago

Closed 6 years ago

#8528 closed Bug (fixed)

Remove unused imagePreviewBoxId in image dialog

Reported by: Alfonso Martínez de Lizarrondo Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: CKEditor 3.6.3
Component: UI : Dialogs Version: 3.6.2
Keywords: Cc:

Description

The preview box has a unique id that it isn't used and it isn't available as part of any API because it's locked inside a closure, so I think that it can be safely removed.

Attachments (1)

8528.patch (1.2 KB) - added by Alfonso Martínez de Lizarrondo 6 years ago.
Proposed patch

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by Alfonso Martínez de Lizarrondo

Attachment: 8528.patch added

Proposed patch

comment:1 Changed 6 years ago by Alfonso Martínez de Lizarrondo

Owner: set to Alfonso Martínez de Lizarrondo
Status: newreview

comment:2 Changed 6 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.6.3
Status: reviewreview_passed

comment:3 Changed 6 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: review_passedclosed

Fixed with [7380]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy