Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#8681 closed Bug (invalid)

Themes css update recommended

Reported by: Michal Malének Owned by:
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description

I'd like to recommend adding the following lines into the themes css definition: li.cke_panel_listItem { list-style:none; } li.cke_panel_listItem a { border-color:transparent; } Without the first one, the panel (format, style...) adds a weird margin in IE(8,9) in some cases, the latter adds uggly border in case of dark backgrounds (there is a white border that is not visible in case of a white background).

Attachments (2)

ckformat.png (7.3 KB) - added by Michal Malének 8 years ago.
None of the recommended styles applied - the first is applied - both are applied (IE9)
ie6_border.png (3.8 KB) - added by Jakub Ś 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Michal Malének

Attachment: ckformat.png added

None of the recommended styles applied - the first is applied - both are applied (IE9)

comment:1 Changed 8 years ago by Jakub Ś

Resolution: invalid
Status: newclosed
Version: 3.6.2

adds a weird margin in IE(8,9) in some cases

What are those cases.

When looking at rules you have mentioned I have found li.cke_panel_listItem { margin : 0; so I'm not sure in what situation this margin will be created.

li.cke_panel_listItem a { border-color:transparent;} perhaps this will do for IE8 and IE9 but in IE6 border set to transparent will be visible as black what is unacceptable in case of white or any other background than black (See attachment).

I’m closing this issue as invalid. Please provide a your example or leave a comment if you think this should be changed despite the black border in IE6.

Changed 8 years ago by Jakub Ś

Attachment: ie6_border.png added

comment:2 Changed 8 years ago by Michal Malének

As far as the first style rule is considered, IE obviously creates the margin in case that list-style isn't set to none (despite the fact that it is actually set to margin:0). I didn't really analyze all the scenarios as for when IE adds this unwanted margin but I don't think it would hurt to add the list-style:none rule as it is actually what we want and it works in all cases.

As far as the latter is considered - I'm no longer concerned about IE6 but I do understand that you are - in that case border-color:transparent; _border-color:white; would do the trick (with some graceful degradation for IE6).

One way or another - it's not so crucial for me personally as my CMS passes the recommended styles to CKEditor already but I believe that others might sometimes wonder why the dropdown panels act funny.

comment:3 Changed 8 years ago by Jakub Ś

What you say sounds correct but I still haven't yet seen the code that is actually causing the problem. Any chance for a reduced Test Case (sample page/css/plugin/etc.) backing up all you have written above?

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy