Opened 13 years ago
Closed 13 years ago
#8857 closed Bug (fixed)
wrong variable "name" used instead of "tagName"
Reported by: | Alfonso Martínez de Lizarrondo | Owned by: | Alfonso Martínez de Lizarrondo |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6.4 |
Component: | Core : Parser | Version: | |
Keywords: | Cc: |
Description
In the core/htmlparser/element.js file, this block
var tagName = attributes[ 'data-cke-real-element-type' ] || name || ''; // Reveal the real semantic of our internal custom tag name (#6639). var internalTag = tagName.match( /^cke:(.*)/ ); internalTag && ( tagName = internalTag[ 1 ] ); var dtd = CKEDITOR.dtd, isBlockLike = !!( dtd.$nonBodyContent[ tagName ] || dtd.$block[ tagName ] || dtd.$listItem[ tagName ] || dtd.$tableContent[ tagName ] || dtd.$nonEditable[ tagName ] || tagName == 'br' ), isEmpty = !!dtd.$empty[ name ]; this.isEmpty = isEmpty; this.isUnknown = !dtd[ name ];
I think that the "name" in lines 50 and 53 should be tagName as all the rest of uses, but instead of applying it as a microchange I would prefer if someone could confirm it.
Attachments (1)
Change History (4)
Changed 13 years ago by
Attachment: | 8857.patch added |
---|
comment:1 Changed 13 years ago by
Owner: | set to Alfonso Martínez de Lizarrondo |
---|---|
Status: | new → review |
comment:2 Changed 13 years ago by
Milestone: | → CKEditor 3.6.4 |
---|---|
Status: | review → review_passed |
comment:3 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [7542].
Proposed patch