Opened 8 years ago

Closed 8 years ago

#8885 closed Bug (invalid)

make ckeditor_php4.php and ckeditor_php5.php independent of hardcoded filenames

Reported by: bugmenot Owned by:
Priority: Normal Milestone:
Component: Server : PHP Version:
Keywords: Cc:

Description

patch attached

Attachments (1)

patch.diff (1004 bytes) - added by bugmenot 8 years ago.

Download all attachments as: .zip

Change History (2)

Changed 8 years ago by bugmenot

Attachment: patch.diff added

comment:1 Changed 8 years ago by Jakub Ś

Keywords: improvement removed
Resolution: invalid
Status: newclosed
Version: 3.6.2
  1. Let's assume that sequence of included files changes - there is no guarantee that we won't add anything in the future or better that user will not add any custom script in his CKEditor. In that case $ckeditorUrl might became invalid and cause error.
  2. Your method uses two extra functions.
  3. Thank you for improvement proposition but in this case we will stick to old version of code.
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy