Incorrect font size shown for <font> tag

[Teresa Monahan]

To Reproduce:

• Open any CKEditor sample and copy the following into the Source view:

<p>
	<font size="3">Sample Text</font></p>

• Return to wysiwyg mode and click on the text in the editor.

Problem: The font size combo box displays the first font size in the list i.e. 8. It should not display any size.

This is confusing for the user because if they think the font size is 8 and wish to make it bigger e.g. 12, the font size actually gets smaller when size 12 styling is applied.

[Jakub Ś]

Issue reproducible in all browsers from CKEditor 3.0

[Garry Yao]

Call for a conceptual review.

[Frederico Caldeira Knabben]

The root of the problem here seems to be the semantic meaning of the API.

The "checkElementRemovable" method is supposed to "check if the element is removable by the style". It's should not check if "the element matches the style".

Those are different needs. The first takes in consideration overrides and can be used by things like the bold button, which doesn't have variations and acts just like "add and remove".

The second instead does not look at overrides and can be used by features that should not match overrides, but should still suppress them when used (like font size).

So, what if we expand the API with the "checkElementMatch", which will be simply the result of splitting the current "checkElementRemovable" without adding new code?

This would give the very same results of your proposal, but would help us having a more semantically correct API, without adding strange features to it.

[Garry Yao]

​http://ckeditor.t/dt/plugins/style/style.html#test_checkElementMatch

[Frederico Caldeira Knabben]

The new patch simply changed the other of the methods on the styles plugin, to have a simpler diff for the change. Additionally, it reverts most of the unnecessary changes in the font plugin.

[Frederico Caldeira Knabben]

Fixed with [7502].