IE: closing a dialog from a nested editor doesn't unlock the selection

[Alfonso Martínez de Lizarrondo]

This seems a bit complex to follow, but it isn't so much.

Refer to the following post for extra info: ​http://alfonsoml.blogspot.com.es/2010/06/nesting-dialogs-in-ckeditor.html

The process is:

• An editor instance,
• Launches a dialog.
• That dialog launches a new one
• In this dialog we create a new CKEditor
• And now we open a dialog to create a link.

After closing the link dialog the selection isn't unlocked, and that leads to weird problems (remember, this is only for IE, other browsers work fine and that might be the reason why this problem has remained hidden for so long after I started using that setup).

Now that we know the root of the problem, the fix is quite easier.

Is it possible to review it?

[Alfonso Martínez de Lizarrondo]

Proposed patch

[Alfonso Martínez de Lizarrondo]

The patch first moves the changes to the zIndex to a previous check for parentDialog (no real change in behavior) and then adds an extra check so the "destruction" including the unlock of the selection happens if there is no parent dialog or if that dialog belongs to another editor instance.

[Garry Yao]

Looks like a twister, can we have a tick test for this issue?

[Alfonso Martínez de Lizarrondo]

Testcase

[Alfonso Martínez de Lizarrondo]

The sample file goes into the _samples folder and should be self-explainatory. Just remember to use IE.