Opened 5 years ago

Last modified 5 years ago

#9060 review Bug

IE: closing a dialog from a nested editor doesn't unlock the selection

Reported by: Alfonso Martínez de Lizarrondo Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone:
Component: UI : Dialogs Version:
Keywords: Cc:

Description

This seems a bit complex to follow, but it isn't so much.

Refer to the following post for extra info: http://alfonsoml.blogspot.com.es/2010/06/nesting-dialogs-in-ckeditor.html

The process is:

  • An editor instance,
  • Launches a dialog.
  • That dialog launches a new one
  • In this dialog we create a new CKEditor
  • And now we open a dialog to create a link.

After closing the link dialog the selection isn't unlocked, and that leads to weird problems (remember, this is only for IE, other browsers work fine and that might be the reason why this problem has remained hidden for so long after I started using that setup).

Now that we know the root of the problem, the fix is quite easier.

Is it possible to review it?

Attachments (2)

9060.patch (1.4 KB) - added by Alfonso Martínez de Lizarrondo 5 years ago.
Proposed patch
test_9060.html (4.0 KB) - added by Alfonso Martínez de Lizarrondo 5 years ago.
Testcase

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by Alfonso Martínez de Lizarrondo

Attachment: 9060.patch added

Proposed patch

comment:1 Changed 5 years ago by Alfonso Martínez de Lizarrondo

Owner: set to Alfonso Martínez de Lizarrondo
Status: newreview

The patch first moves the changes to the zIndex to a previous check for parentDialog (no real change in behavior) and then adds an extra check so the "destruction" including the unlock of the selection happens if there is no parent dialog or if that dialog belongs to another editor instance.

comment:2 Changed 5 years ago by Garry Yao

Looks like a twister, can we have a tick test for this issue?

Changed 5 years ago by Alfonso Martínez de Lizarrondo

Attachment: test_9060.html added

Testcase

comment:3 Changed 5 years ago by Alfonso Martínez de Lizarrondo

The sample file goes into the _samples folder and should be self-explainatory. Just remember to use IE.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy