Find is always doing a cyclic search even if 'Match cyclic' is not selected

[Teresa Monahan]

To Reproduce:

• Open any CKEditor sample and enter some sample text e.g. 'this is a test'.
• Place the cursor at the end of this text and open the Find dialog.
• Type in a word that does appear in the editor e.g. 'test'
• Uncheck 'Match cyclic' and click Find.

Problem: The text is found even though the word appears before the cursor.

Expected result: The text should not be highlighted and 'The specified text was not found' message should be displayed.

[Piotrek Koszuliński]

First bad commit: ​https://github.com/ckeditor/ckeditor-dev/commit/4040e4f

[Piotrek Koszuliński]

Pushed t/9225.

Reverted part of ​https://github.com/ckeditor/ckeditor-dev/commit/4040e4f. I don't know what was it for and I haven't found any obvious issue breaking find dialog in both inlineall and divarea samples.

Garry, do you remember purpose of that patch?

[Garry Yao]

That line looks like a mistake indeed, but note that the reason for such change still remains:

editor::getSelection would not return null when editor is not focused as in v3, it returns now a selection with type NONE, this's to enable making a selection even when editor is not focused.

But in this case find dialog will always pre-focus the editor, so such guard is not required.

[Garry Yao]

Masterised with:

​https://github.com/ckeditor/ckeditor-dev/commit/030164e709c22b5950ddcbcc9827281603390779