Changes between Initial Version and Version 1 of Ticket #9239, comment 7


Ignore:
Timestamp:
Oct 10, 2012, 8:33:50 AM (10 years ago)
Author:
Garry Yao
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9239, comment 7

    initial v1  
    1 The patch didn't touch the root of the issue, I've pushed t/9239b for a deeper fix.
     1The patch didn't touch the root of the issue, I've pushed t/9239b for a deeper fix, the culprit is that in v4 we unlock selection automatically when focus is returned, while the template dialog has just invalidated the lock selection, in such case a simple silent failure is enough.
    22
    33The rational behind calling all insertion before closing the dialog, is to ensure that user who listened to the dialog#hide really got the result from all jobs done by the dialog.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy