template plugin error prune on divarea

[Garry Yao]

1. Load any divarea sample
2. Insert a default template

• Actual: JS error thrown.

[Piotrek Koszuliński]

WFM. I couldn't reproduce this issue on ​http://localhost/cksource/ckeditor-dev/samples/divarea.html

[Olek Nowodziński]

Also WFM.

[Jakub Ś]

Reproducible in IE7-9.

1. Load divarea sample
2. Clear editor contents. Click new page button or CRTL+A backspace or switch to source delete html and switch to wysiwyg.
3. Insert a default template

You will get invalid argument error.

[Piotrek Koszuliński]

Pushed t/9239.

Fix for #4073 (or some other issue, as I'm not able to find when that patch was really proposed) doesn't seem to be needed still.

[Garry Yao]

The patch didn't touch the root of the issue, I've pushed t/9239b for a deeper fix, the culprit is that in v4 we unlock selection automatically when focus is returned, while the template dialog has just invalidated the lock selection, in such case a simple silent failure is enough.

The rational behind calling all insertion before closing the dialog, is to ensure that user who listened to the dialog#hide really got the result from all jobs done by the dialog.

[Piotrek Koszuliński]

I've got mixed feelings about this patch. It of course fixes the issue, but there always pops out security alert in my head when I see code silently accepting incorrect input. Thus, I think that we should still focus on fixing timing on template dialog close. Only if other way can't be find, this patch makes sense.

[Piotrek Koszuliński]

I pushed t/9239c.

I still believe that the order of action (dialog.hide after editor.setData) is broken and I would change it anyhow, but I'm proposing ensuring that selection is valid on selection.unlock. It's Garry's fix, but in different place - in which it IMO makes more sense.

[Piotrek Koszuliński]

PS. I want to write some tests for this, but let me know what do you think first.

[Piotrek Koszuliński]

Masterised ​https://github.com/ckeditor/ckeditor-dev/commit/a9da7a5 + simple tests.