Opened 7 years ago

Closed 7 years ago

#9238 closed Bug (fixed)

State of some toolbar buttons are not updated after using 'Remove Format'

Reported by: Teresa Monahan Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 4.0
Component: Core : Selection Version: 4.0
Keywords: IBM Cc: Damian, Satya Minnekanti

Description

To Reproduce:

  • Open any editor sample and delete the entire contents of the editor. Enter some plain text - do not apply any font styling.
  • Select the entire contents and click 'Align Right'.
  • Click 'Remove Format'.

Expected Result: The text should move back to the left and the toolbar icons should be updated to show that 'Align Left' is applied.

Actual Result: The text does move back to the left but the 'Align Right' toolbar icon is still selected.

Similarly if you indent the original plain text and then 'Remove Format', the toolbar icons still shows that 'Decrease Indent' is possible when it should not be.

The state of toolbar icons are correctly updated after pressing enter or switching to source mode and back.

Note: This issue does not occur if font styling is applied to the initial text.

Change History (4)

comment:1 Changed 7 years ago by Garry Yao

Component: GeneralCore : Selection
Owner: set to Garry Yao
Status: newassigned

comment:2 Changed 7 years ago by Garry Yao

Status: assignedreview

Opened review request branch t/9238 on dev & test.

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:4 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy