Opened 12 years ago
Closed 12 years ago
#9249 closed Bug (fixed)
Escape key does not close the a11yhelp dialog
Reported by: | Teresa Monahan | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.0 |
Component: | General | Version: | 4.0 |
Keywords: | IBM | Cc: | Damian, Satya Minnekanti |
Description
To Reproduce:
- Open the a11yhelp dialog using the Alt+0 keystroke.
- Press the Esc key to close the dialog.
Problem: The dialog does not close. All other dialogs do close correctly when the Esc key is pressed.
Change History (3)
comment:1 Changed 12 years ago by
Owner: | set to Garry Yao |
---|---|
Status: | new → review |
comment:2 Changed 12 years ago by
Status: | review → review_passed |
---|
I rebased t/9249 + fixed indentation.
comment:3 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Caused by: https://github.com/ckeditor/ckeditor-dev/commit/47f8446b766444c55d2cb307264671b64132914d
We should instead fix the incorrect focus usage on html type field, since html field should only gain focus on requested.