Opened 12 years ago
Closed 12 years ago
#9263 closed Bug (fixed)
config.ignoreEmptyParagraph invalid for inline
| Reported by: | Garry Yao | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.0 |
| Component: | General | Version: | 4.0 |
| Keywords: | Cc: |
Description
- Open inlineall sample
- Click on New Page
- Check the editor data from console.
CKEDITOR.instances.main.getData()
- Actual: <p> </p>
- Expected: empty
Change History (8)
comment:1 Changed 12 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | new → review |
comment:2 Changed 12 years ago by
The following tc is on subject:
/dt/core/config/ignoreEmptyParagraph.html (config.creator = "inline")
comment:5 Changed 12 years ago by
| Status: | review → review_failed |
|---|
I'm also finding this duplication a bit strange, but still hard to determine if it's for good or for bad.
In any case, I was able to find the bad side of it. In the inlinebycode sample, if you call CKEDITOR.instances.editable.getData(), the cleanup logic is calle twice (I've added console.log tracing on the code). This leads to think that a non optimal approach has been taken.
comment:6 Changed 12 years ago by
| Status: | review_failed → review |
|---|
Sorry guys...it's a pure mistaken, the idea is to make the cleanup happening on "beforeGetData", so all wysiwyg editable types will get the same fix.
comment:7 Changed 12 years ago by
| Status: | review → review_passed |
|---|
comment:8 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Note: See
TracTickets for help on using
tickets.
config.ignoreEmptyParagraph should now become a core feature.