Opened 7 years ago

Closed 7 years ago

#9263 closed Bug (fixed)

config.ignoreEmptyParagraph invalid for inline

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 4.0
Component: General Version: 4.0
Keywords: Cc:

Description

  1. Open inlineall sample
  2. Click on New Page
  3. Check the editor data from console.
    CKEDITOR.instances.main.getData()
    
  • Actual: <p>&nbsp;</p>
  • Expected: empty

Change History (8)

comment:1 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

config.ignoreEmptyParagraph should now become a core feature.

comment:2 Changed 7 years ago by Garry Yao

The following tc is on subject:

/dt/core/config/ignoreEmptyParagraph.html (config.creator = "inline")

comment:3 Changed 7 years ago by Piotrek Koszuliński

I rebased branch and pushed docs fix.

comment:4 Changed 7 years ago by Piotrek Koszuliński

Why is the clean up done twice on getData?

comment:5 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

I'm also finding this duplication a bit strange, but still hard to determine if it's for good or for bad.

In any case, I was able to find the bad side of it. In the inlinebycode sample, if you call CKEDITOR.instances.editable.getData(), the cleanup logic is calle twice (I've added console.log tracing on the code). This leads to think that a non optimal approach has been taken.

comment:6 Changed 7 years ago by Garry Yao

Status: review_failedreview

Sorry guys...it's a pure mistaken, the idea is to make the cleanup happening on "beforeGetData", so all wysiwyg editable types will get the same fix.

comment:7 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:8 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy