Opened 7 years ago

Last modified 7 years ago

#9268 review_failed Bug

Migrate to env.version for IE check

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone:
Component: General Version: 4.0
Keywords: Cc:

Description

Current code that use deprecated env check, e.g. ie8Compat, should be migrated to env.version check.

Change History (2)

comment:1 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

comment:2 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 4.0
Status: reviewreview_failed

The problem with this change is that we're changing the semantics of env.version. Until now, IE9+Quirks was setting env.version to "9". Now, it'll be "6".

While it would be ok when replacing ie6Compat entries all around the code, it'll also impact parts of the code that already use env.version for checking.

For example, we have several ( CKEDITOR.env.ie && CKEDITOR.env.version < 9 ) checks in he code. Until now, these checks where not catching IE9+Quirks, but now they will do. This may bring unexpected results.

This ticket is supposed to be a 1 to 1 change (basically no real changes). So we should not change the way env.version works, but instead just cleanup the usage of env.ieXCompat, if possible.

In any case, there is little to zero priority on this. Let's just remember to not use env.ieXCompat from now in.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy