Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#9277 closed Bug (fixed)

[API docs] Scrolling to anchor doesn't work precisely

Reported by: Piotrek Koszuliński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.0
Component: General Version: 4.0
Keywords: Cc:

Description

See e.g.

http://nightly-v4.ckeditor.com/ckeditor_api/#!/api/CKEDITOR.editor-method-setReadOnly

Header of setReadOnly method is hidden. This doesn't happen on JSDuck by default and I guess it's caused by our change of docs header's height.

Change History (8)

comment:1 Changed 7 years ago by Frederico Caldeira Knabben

Status: newconfirmed

comment:2 Changed 7 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: confirmedassigned

comment:3 Changed 7 years ago by Olek Nowodziński

Status: assignedreview

Created branch t/9277.

Reverted docs to defaults with tiny header (no logo) which solves the problem. The appearance will be balanced with welcome page proposed in #9327.

comment:4 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

I think we need to file an issue for the JSDuck.

comment:5 Changed 7 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Fixed with this commit .

comment:6 in reply to:  4 Changed 7 years ago by Olek Nowodziński

Replying to garry.yao:

I think we need to file an issue for the JSDuck.

I don't think so as what we've done before was a hack and we cannot expect them to make it working by default.

comment:8 Changed 7 years ago by Garry Yao

JSDuck fix has landed on master and to be included in JSDuck version 4.1.2.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy