Opened 7 years ago

Closed 7 years ago

#9279 closed Bug (fixed)

Divarea vs inline editor - styling problems

Reported by: Piotrek Koszuliński Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 4.0
Component: General Version: 4.0
Keywords: Cc:

Description

  1. To style both focused editables - normal inline one and created with divarea I had to write to selectors: https://github.com/ckeditor/ckeditor-dev/commit/16f0f5c Nothing really serious, but other selectors may have to be doubled too and maybe this wasn't intended :).
  2. I also noticed that divarea inherits the same box-shadow: inset huge rule which styles other inline editors. This shows power of inline editing, but also doesn't look very well - maybe we want to disable this rule somehow.

Change History (7)

comment:1 Changed 7 years ago by Piotrek Koszuliński

I've found another issue. Sourcearea has cke_editable class, so it inherits the same box-shadow as in 2). Basing on existing classes if I want to style only content of inline editor, I have to use .cke_editable[contenteditable=true] selector which isn't supported in old IEs. I believe we should do some clean up in these classes, to allow writing simple selectors for all type of editables (with special conditions for focused or not, ltr/rtl, etc).

comment:2 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

Proposed creator specific class name on editable, to provide better flexibility when styling editable.

comment:3 Changed 7 years ago by Piotrek Koszuliński

Resolution: fixed
Status: reviewclosed

comment:4 Changed 7 years ago by Garry Yao

"pointer" is not the correct cursor shape, fixed into "default" instead.

https://github.com/ckeditor/ckeditor-dev/commit/62bca77ecc2a9923bf83eb5b69cb0953348d3e26

comment:5 Changed 7 years ago by Piotrek Koszuliński

Resolution: fixed
Status: closedreopened

"pointer" is a correct cursor shape. It points that this box can be clicked. That this will be followed by some reaction. The default cursor shows nothing at all - default means that there's no special thing about these boxes.

Please revert your change.

comment:6 Changed 7 years ago by Garry Yao

The editable is not an interactive element of the page, but by it's nature an editable section, and it does not react to mouse click, upon mouse down it will be enough to show the cursor, so I dont consider "hand" to be the proper cursor here.

comment:7 Changed 7 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: reopenedclosed

I have reverted the cursor to pointer with f3257dc because in fact the editable is a very interactive element and it makes more sense in that way. It's easier to discover the editable and it reacts to the click.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy