Opened 7 years ago

Closed 3 years ago

#9300 closed Bug (expired)

Move keystroke handlers

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone:
Component: Core : Keystrokes Version: 4.0
Keywords: Cc:

Description

Currently we hooked all keystroke handles, inside of editable.js, it has the following cons:

  • Even if native behavior canceled by keydown listener, is still firing editor#key event, which should not happen.
  • Bad to continue enlarging editable.js code lines

core/keystrokehandler.js would be a proper new home for them.

Change History (5)

comment:1 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

comment:2 Changed 7 years ago by Garry Yao

Opened t/9300 on both dev/test for review.

Besides of this change, I'd also propose to move the list related handles into core as well, from the list plugin, but need your opinion?

comment:3 Changed 7 years ago by Garry Yao

Status: reviewpending

As another option, is to move the keystroke handlers, into their dedicated plugin, considering that the current code are pretty much structural element related, so probably the list/table keystroke will not be needed until the corresponding plugin is used, how do u c?

comment:4 Changed 7 years ago by Garry Yao

Milestone: CKEditor 4.0

Re-targeted because of it's pending status.

comment:5 Changed 3 years ago by Jakub Ś

Resolution: expired
Status: pendingclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy