Opened 7 years ago

Last modified 6 years ago

#9336 confirmed Bug

Automatically generated toolbar duplicates items that are included in a toolbar menu

Reported by: Teresa Monahan Owned by:
Priority: Normal Milestone:
Component: General Version: 3.0
Keywords: IBM Cc: Damian, Satya Minnekanti

Description

It is possible to define toolbar menus in CKEditor which can be used to combine a number of toolbar icons into one collection. If toolbar menus are defined, and no config.toolbar value is provided, the toolbar is automatically generated in v4. However any icon included in the toolbar menu is included in the toolbar twice: once in the menu, and once as an individual toolbar icon.

To see an example of this, save the attached plugin and sample file into their respective directories and run in any browser.

Notice how the toolbar contains a Paste Menu which combines all paste icons into one toolbar entry. However the individual Paste icons are also available on the toolbar.

If a toolbar button is included in a toolbar menu, it should not also appear as an individual toolbar icon. Is there any way to prevent this from happening? Is it possible to exclude toolbar icons from the automatically generated toolbar if they are already part of a CKEDITOR.UI_MENUBUTTON?

Attachments (3)

pastemenu.zip (580 bytes) - added by Teresa Monahan 7 years ago.
toolbarmenu.html (458 bytes) - added by Teresa Monahan 7 years ago.
workaround.zip (1.1 KB) - added by Jakub Ś 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Teresa Monahan

Attachment: pastemenu.zip added

Changed 7 years ago by Teresa Monahan

Attachment: toolbarmenu.html added

comment:1 Changed 6 years ago by Jakub Ś

Status: newconfirmed
Version: 4.0 (GitHub - master)3.0

It has been working that way from CKEditor 3.0.
I will confirm this issue. I'm not sure however if editor should by default hide toolbar buttons i they are available in the menu. Perhaps there will be users that will want that. The more options editor can handle the better IMHO.

Really would like to hear someone else's opinion on this.

@tmonahan your issue can be workaround. Please see workaround.zip
If you define toolbar then other buttons are not available.

NOTE: Looks like it does not matter but the first time I was checking this I defined pastemenu before all other paste plugins.

clipboard,contextmenu,elementspath,menu,menubutton,pastemenu,pastefromword,pastetext,toolbar,wysiwygarea

Later it has worked as expected without it so it could have been just cache issue.

Changed 6 years ago by Jakub Ś

Attachment: workaround.zip added
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy