Opened 6 years ago

Closed 6 years ago

#9412 closed Bug (fixed)

Option toolbarStartupExpanded = false does not work as expected

Reported by: Jakub Ś Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.0
Component: UI : Toolbar Version: 4.0
Keywords: Cc:

Description

This was reported by @ansonhoyt - https://gist.github.com/3799646 Start editor with option

config.toolbarStartupExpanded = false;

or

config.toolbarStartupExpanded = false;
config.toolbarCanCollapse = true;

Editor loads without toolbar and there is no collapse button thus you can use the toolbar.

Attachments (1)

9412.html (605 bytes) - added by Garry Yao 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 6 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.0

comment:3 Changed 6 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: confirmedassigned

comment:4 Changed 6 years ago by Piotrek Koszuliński

Status: assignedreview

Pushed t/9412 on both dev&tests.

Changed 6 years ago by Garry Yao

Attachment: 9412.html added

comment:5 Changed 6 years ago by Garry Yao

Component: GeneralUI : Toolbar
Status: reviewreview_failed

Toolbar collapse feature is for themed UI only, thus the patch breaks the toolbar used in a floating space, as shown in the attached test file.

comment:6 Changed 6 years ago by Piotrek Koszuliński

Status: review_failedreview

Patch hasn't broken anything - it was broken from the beginning.

Pushed commits on dev&tests switching collapsing for inline editor.

comment:7 Changed 6 years ago by Garry Yao

Status: reviewreview_passed

comment:8 Changed 6 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy