Opened 12 years ago
Closed 12 years ago
#9465 closed Bug (fixed)
Misplaced panels when editor is being maximized
| Reported by: | Olek Nowodziński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.0 |
| Component: | UI : Floating Panel | Version: | 4.0 |
| Keywords: | Cc: |
Description
- Open http://ckeditor4.t/ckeditor/samples/replacebycode.html
- Open a panel (for example a text colour panel).
- Click maximize.
- See things flying here and there.
PS. There's already a maximize event implemented which can be used to solve this problem.
Attachments (1)
Change History (9)
Changed 12 years ago by
| Attachment: | misplacedPanelOnMaximize.png added |
|---|
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
| Status: | new → confirmed |
|---|
comment:3 Changed 12 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | confirmed → assigned |
comment:4 Changed 12 years ago by
| Status: | assigned → review |
|---|
TC1 (misplaced panels) isn't a regression sinve v3, but after introducing maximize event it was trivial to fix.
TC2 (invisible context menu) was an issue caused by incorrect z-index.
I pushed t/9465.
comment:5 Changed 12 years ago by
| Status: | review → review_failed |
|---|
It's not a good practise to have one plugin aware of other plugin's specific event (maximize), editor#resize event should be used instead, as a core event to coordinate edito resizing.
The baseFloatZIndex related fix looks good though.
comment:6 Changed 12 years ago by
| Status: | review_failed → review |
|---|
Ok - I pushed version with 'resize'.
comment:7 Changed 12 years ago by
| Status: | review → review_passed |
|---|
comment:8 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Note: See
TracTickets for help on using
tickets.
Another TC:
It's invisible, but it's opened, because I was able to navigate through it with keyboard.