V4 and IE: It is not possible to insert table in enter mode other than P

[Jakub Ś]

To reproduce:

1. Go to enterkey.html sample
2. Set enter mode to DIV or BR using dropdown list
3. Click New Page button to remove contents
4. Click Table button and press OK in table dialog.

Result JS errors pop out:
IE9
Message: CRIPT5007: can't get property type. It is null or undefined.
Line: 1469
URI: ckeditor4/code/dom/range.js

Message: SCRIPT5007: can't get property childNodes. It is null or undefined.
Line: 94
URI: ckeditor4/code/dom/text.js

IE8 and IE7
Message: Invalid argument
Line: 444
URI: ckeditor4/core/dom/node.js

[Garry Yao]

It's a generic selection error that occurs always when restoring the selection, but the error raised only when cursor is collapsed inside of an empty editable, an invalid range is restored from the unlock selection in the following case:

1. Load editor in enterMode BR
1. Click on "New Page";
1. Click outside of the editor, then use TAB key to move focus back.

It looks like just an IE selection quirks, and I didn't find other better way to fix this issue other than catching the error thrown when trying to restore a locked selection.

[Piotrek Koszuliński]

Error is thrown after range is selected in:

• native selectionchange,
• checkSelectionChange,
• elementPath constructor,
• getSelection().getStartElement(),
• range.optimize().

Start and end container of this range is text node which is not present in DOM (body.getFirst() === null), so IMO this issue is caused by incorrect result of getSelection().getRanges(). Could you check that?

[Garry Yao]

Some deeper investigation shows that the error is caused by the selection filler text used with a collapsed cursor, opened t/9474b for the 2nd review.

[Piotrek Koszuliński]

I see no difference on IE8 between master and t/9474b.

[Garry Yao]

It turns out t/9474b doesn't really help with the issue, opened t/9474c for review.

[Garry Yao]

Fixed on master with:

​https://github.com/ckeditor/ckeditor-dev/commit/a0b7b1c5e2fa4d8eb54b6d53f33005060c839305

[Piotrek Koszuliński]

Unfortunately it looks that I missed some reds this patch is introducing on IE8:

• /dt/plugins/enter/enterkey.html#test enter key scrolls document
• /dt/plugins/link/link.html#test create link
• /dt/plugins/link/link.html#test create link (with editor focus)

[Piotrek Koszuliński]

I reverted ​https://github.com/ckeditor/ckeditor-dev/commit/a0b7b1c with ​https://github.com/ckeditor/ckeditor-dev/commit/87a719c9

[Garry Yao]

Re-created t/9474 for review.

[Garry Yao]

Fixed on master with:

​https://github.com/ckeditor/ckeditor-dev/commit/10272e460ab1d46883af985dc55099e241ef61a6

Check github commit for clarifications.