Extra files in skins/moono folder

[Wiktor Walc]

Did not check but I guess they're not used anywhere per se:

• icons.svg
• icons_export_16.png

total size: 250kB.

I believe something must be done with them in order to reduce the size of release package.

[Piotrek Koszuliński]

Olek (cced) will know, but AFAIK they are completely needless in release package.

[Frederico Caldeira Knabben]

I agree that icons_export_16.png can be deleted.

As for icons.svg, it is the "source" version of the icons, so it is ok to have it on dev. In the other hand, we need to have a way to tell the builder to ignore it.

[Wiktor Walc]

One of the possible solutions would be to introduce manifest.js. It could be used to remove various files that are not needed in the release package.

var MANIFEST = {
	ignore: [
		'icons.svg'
	]
}

If we are going to introduce this, we could consider adding the dependency information to the manifest file as well. Right now I'm using regex to parse the requires: statement in plugin.js. It works quite well at this moment, but is a bit ugly. On the other side, the dependency information would be duplicated in two places (the manifest file & plugin.js), so have no idea which option is better.

[Wiktor Walc]

After a bit more of thinking I changed my mind, I think the right place for all development stuff is... the "dev" subfolder of a skin/plugin. This subfolder could be ignored by builder, just like the "root" /dev folder.

So, if we want to keep some "source version" of a file with all icons, let's put it into dev/icons.svg, even along with a custom script that can cut the file into separate icons.

If we want to keep some "development" samples that are not to be included in the release (like plugins/magicline/samples/sample.html), let's put them into the "dev" folder to avoid confusion, and so on.

What do you think?

[Frederico Caldeira Knabben]

Good idea... let's proceed with the "dev" folder.

[Piotrek Koszuliński]

Pushed t/9512.

I've cleaned up samples and source files by moving them to dev folders or removing ones that are doubled (which are in global samples folder and inside plugins).

I also thought that it'll nice to have builder flag --leave-dev-folders/dirs, because e.g. sometimes I need clipboard sample in release version, as it helps to verify if everything works fine.

And one more thought regarding samples builder - please remember that we need them also in dev mode, so they should work after moving them to plugins folders.

[Piotrek Koszuliński]

Samples builder is targeted by #9564, so this ticket goes on review.

[Wiktor Walc]

@Reinmar "dev" is already ignored thanks to the "ignore" entry in build-config.js. So in order to keep the dev folders in release version, simply correct the "ignore" array in build-config.js.

[Piotrek Koszuliński]

Masterised ​https://github.com/ckeditor/ckeditor-dev/commit/9df7529