Opened 6 years ago

Closed 6 years ago

#9514 closed Bug (fixed)

Two list buttons active at the same time

Reported by: Piotrek Koszuliński Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 4.0
Component: Core : Lists Version: 4.0
Keywords: Cc:

Description

  1. Set editor contents to '<ul><li><ol><li>a</li></ol></li></ul>'.
  2. Place cursor in the list item (before/after 'a').
  • Expected: only numbered list button is highlighted (v3's behaviour).
  • Actual: both list buttons are highlighted.

In fact I don't know whether v3's behaviour was correct, so that may not be a bug.

Change History (5)

comment:1 Changed 6 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

Opened t/9514 for review.

comment:2 Changed 6 years ago by Piotrek Koszuliński

Status: reviewreview_failed

Issue is fixed, but 4 tests are failing in http://ckeditor4.t/dt/plugins/list/list.html

comment:3 Changed 6 years ago by Garry Yao

Status: review_failedreview

Ok, I figured out from this failure, that for impl of command:refresh method, the in fact "return value" is mandatory, otherwise the command will keep the old state even when checked on selection change.

From the API design principle it would better to force a return value (as determined command state) for this method, but I'm just compensating the docs for now.

Opened t/9514 on test as well.

comment:4 Changed 6 years ago by Piotrek Koszuliński

Status: reviewreview_passed

I pushed corrected doc string.

comment:5 Changed 6 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy