Opened 6 years ago

Closed 6 years ago

#9521 closed Bug (fixed)

[Opera&IE] JS error when inserting content into the editor after setData on blurred editor

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.0
Component: Core : Selection Version: 4.0
Keywords: Cc:

Description

  1. Open API sample.
  2. Focus editor.
  3. Blur editor.
  4. Set data.
  5. Insert text.

Error is thrown.

Change History (5)

comment:1 Changed 6 years ago by Piotrek Koszuliński

Component: GeneralCore : Selection
Owner: set to Piotrek Koszuliński
Status: newassigned

comment:2 Changed 6 years ago by Piotrek Koszuliński

Status: assignedreview

Pushed t/9521 on dev&tests.

Besides restoring outdated selection after content DOM unload, insertText was focusing editor too late.

comment:3 Changed 6 years ago by Piotrek Koszuliński

BTW. There's similar clearSelection listner on setData for Webkit - I don't know that issue, but maybe proposed patch makes that redundant.

comment:4 Changed 6 years ago by Garry Yao

Status: reviewreview_passed

Not it's not redundant, that line is to clear the DOM selection in effect.

comment:5 Changed 6 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Masterised https://github.com/ckeditor/ckeditor-dev/commit/ddd2fb6

Before masterising I reverted part of the patch on Opera and reported issue that forced me to do this (#9568). This patch (scrolling after insertElement) wasn't made by me on purpose and it was not part of this ticket.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy