Opened 7 years ago

Closed 7 years ago

#9535 closed Bug (fixed)

[IE10] Wrong cursor position after enter BR

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 4.0
Component: UI : Enter Key Version: 3.0
Keywords: IE Cc: michiel.beijen@…

Description

  1. Load any sample page with enter mode as BR;
  2. Clear all content, type some chars
  3. Enter key pressed twice
  • Actual: Cursor moves to the second line;
  • Expected: Cursor moves to the third line;

Change History (8)

comment:1 Changed 7 years ago by Garry Yao

Besides, enter key in preformatted is also partially broken as cursor is not moving to the next line.

comment:2 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: newreview

Opened t/9535 for review.

comment:3 Changed 7 years ago by Garry Yao

The ticket tc on IE10, depends on the result of retrieving the following selection range:

foo
<br />^
bar

Which incorrectly returns the range anchored before BR element.

We had conversation before regard switching to W3C DOM selection, but had been worried about the stabality.

For now the suite of selection test has established, it's less risky to consider this change, at least for IE10.

The patch proposed this change for IE10 only, as it eliminates several selection regard quirks like the ticket tc, the tests results are passing and I did some manual tests to verify it.

comment:4 Changed 7 years ago by Garry Yao

It's revealed on #9452 another IE bug when using old MS selection API, once BR is contained inside of text selection from right-to-left, this time on IE9 as well, so it would be well worthy to consider IE9 on subject of this change as well.

Last edited 7 years ago by Garry Yao (previous) (diff)

comment:5 Changed 7 years ago by mwb

Cc: michiel.beijen@… added

comment:6 Changed 7 years ago by Garry Yao

The selection change is masterised, now the ticket branch contains only the patch for fix inside of <pre>.

comment:7 Changed 7 years ago by Piotrek Koszuliński

Status: reviewreview_passed

I couldn't test IE10, but I haven't found regressions on other browsers.

comment:8 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy