Opened 7 years ago

Closed 7 years ago

#9552 closed Bug (fixed)

[IE] Paste from toolbar on which security alert is opened isn't caught

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.0
Component: Core : Pasting Version: 4.0
Keywords: IE Cc:

Description (last modified by Piotrek Koszuliński)

  1. Open clipboard sample.
  2. Click paste/paste as text/paste from word button.
  3. Allow clipboard access.
  4. Content was pasted, but it wasn't caught by pastebin. This may be verified on clipboard sample.
  5. Next paste button click will be handled correctly, because it doesn't open security alert.

Change History (8)

comment:1 Changed 7 years ago by Piotrek Koszuliński

Description: modified (diff)
Owner: set to Piotrek Koszuliński
Status: newassigned

comment:2 Changed 7 years ago by Piotrek Koszuliński

comment:3 Changed 7 years ago by Piotrek Koszuliński

This is one of the most twisted issues I was debugging so far :).

I haven't got decent patch yet, but this is what I learnt:

  1. We're correctly creating, appending and selecting pastebin before content is pasted.
  2. When we accept security alert selection is back in body, not in the pastebin, so content is pasted there.

Why?

  1. IE fires blur on editable when opening security alert. Before 4086b04 selection was locked on this event, but currently it's locked on beforedeactivate. What that means? That now it's done quicker, when the selection is still in editable. Previously it was done a little bit too late, so selection inside pastebin was locked.
  2. After accepting security alert selection that was saved in 1. is immediately restored, because focus is fired on editable. Before 4086b04 selection inside pastebin was restored, now inside editable.
  3. Thus content is pasted in a wrong place.

I have to find a clear way to store selection inside pastebin, or to prevent focus&blur in right moments. There are number of events fired when security alerts is popping out, so it's not easy to anticipate what'll happen.

comment:4 Changed 7 years ago by Piotrek Koszuliński

Status: assignedreview

Pushed t/9552.

comment:5 Changed 7 years ago by Garry Yao

Content was pasted, but it wasn't caught by pastebin.

What exactly proves the above assumption? I got it WFM, all IEs properly processed the pasted html.

comment:6 Changed 7 years ago by Piotrek Koszuliński

Description: modified (diff)
Summary: [IE] First paste from toolbar causing security alert isn't caught[IE] Paste from toolbar on which security alert is opened isn't caught

comment:7 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

R+ for the patch, additionally I pushed a commit to remove a wrong commit from an old ticket which cannot be produced anymore.

comment:8 Changed 7 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy