Opened 7 years ago

Last modified 7 years ago

#9590 confirmed New Feature

Optimize the browser specific css

Reported by: Alfonso Martínez de Lizarrondo Owned by:
Priority: Normal Milestone:
Component: Project : CKBuilder Version: 4.0
Keywords: Cc:

Description

Currently there are some browser-specific css files in the skins, but those files are generated only by adding the overrides to adjust the behavior.

A further step would be to clean up them from properties aimed at the other browsers.

Simple example: moonoo\editor_ie8.css includes this:

-moz-box-shadow:0 0 3px rgba(0,0,0,.15);
-webkit-box-shadow:0 0 3px rgba(0,0,0,.15);
box-shadow:0 0 3px rgba(0,0,0,.15)

But it's clear that for IE the moz or webkit properties are garbage and IE8 doesn't recognize box-shadow so all of that can be removed.

similar things happens with the rest of browser specific properties, anything -moz or -webkit is dead code in the IE files, and some advanced css properties can also be removed from the ie7 and ie8 versions.

And having such IE specific files, all the -ms or filter:progid can be removed from the generic editor.css file.

This is something that has to be done automatically: get the input css file and remove from it a list of rules before trying to compress it.

Benefits: Smaller footprint (faster download) and faster parser time during runtime each time the browser has to parse the css file as it has less things to care about. (As well as avoid poluting the error console and people reporting those harmless warnings as errors in the editor itself.)

Change History (1)

comment:1 Changed 7 years ago by Jakub Ś

Status: newconfirmed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy