Bad toolbar margins with toolbarLocation = 'bottom'

[Frederico Caldeira Knabben]

With the following configuration:

config.removePlugins = 'elementspath,resize';
config.toolbarLocation = 'bottom';

The toolbar should have the same margin space at the top and the bottom.

Additionally, the top space of the editor should not be rendered. It should be just a 1px line, just like the left and right borders. (Just like #9618)

[Frederico Caldeira Knabben]

Issue screenshot.

[Olek Nowodziński]

Added a sandbox​ for the issue.

[Olek Nowodziński]

Pushed solution to t/9619@cksource. It also solves #9618.

Known issues:

• IE7: Editor2 and Editor4 have double borders (respectively: top and bottom). I'm unable to get rid of them since the browser keeps displaying .cke_top/.cke_bottom even if they're empty with font-size = line-height = 0px, no margins and no paddings.
• IE7/IE8: filter: progid:DXImageTransform.Microsoft.gradient is buggy and impacts parent borders (sic!). Sometimes they're invisible for .cke_top/.cke_bottom.

[Piotrek Koszuliński]

I confirm that this and #9618 are fixed with small issues you've mentioned that I think are acceptable.

However, I also noticed that paddings in toolbar changed, but I find this good. But lets have other guys' acceptance for this if this change was intended.

[Frederico Caldeira Knabben]

I tried to advice you guys earlier, as the root of the problem is something else, not CSS. Unfortunately the harder way of fixing it has been chosen and it is even buggy.

Additionally, the extra padding we have on Moono is a kind of skin signature, giving it a bit of relaxing. The new proposal (too late for it) makes everything more crowded.

I've coded a 5 mins fix for the border issue (#9618 as well), by recovering the v3 way for this. You can find it on t/9619b @cksource and @tests.

It's still missing a fix for the padding issue.

[Frederico Caldeira Knabben]

I'm cancelling the review because in fact there is till not fix for the padding.

[Olek Nowodziński]

Fixed padding issue with a commit into t/9619b.

[Frederico Caldeira Knabben]

The current padding on toolbar bottom and elements path has been changed. We should not change the current status of things - simply fix the issue that happens when changing the configuration as described.

[Olek Nowodziński]

Updated t/9619b again.

[Garry Yao]

With elementspath plugin loaded, this configuration results in a crowed bottom space (compared to v3)

[Piotrek Koszuliński]

In v3 it doesn't look very well too.

I think that toolbar at the bottom makes sense only if elements path isn't loaded or if it's displayed at the top (that could be nice feature - they would create some kind of breadcrumbs).

[Olek Nowodziński]

​Masterized t/9619b.