Opened 7 years ago

Closed 7 years ago

#9621 closed Bug (fixed)

No focus style for disabled buttons

Reported by: Frederico Caldeira Knabben Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.0
Component: UI : Skins Version: 4.0
Keywords: Cc:

Description

Unlike v3, v4 doesn't have any styling for disabled buttons on the toolbar:

  1. Put the focus in the editor.
  2. ALT+F10 to focus the toolbar.
  3. TAB to move to any toolbar group with disabled icons.
  4. ARROW-RIGHT to move among the buttons.

Note that the disable buttons have no style, so the focus gets visibly lost.

Disabled buttons should simply use the background styles used on hover of enabled buttons when they have focus.

Change History (6)

comment:1 Changed 7 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: newassigned

comment:2 Changed 7 years ago by Olek Nowodziński

Status: assignedreview

Created t/9621@cksource with a fix.

comment:3 Changed 7 years ago by Garry Yao

Status: reviewreview_failed
  • Hover style is still missing
  • High-contrast is not affected by this fix.

Pushed the fix for that 50a0ef7799 (No focus style for disabled buttons.)

Last edited 7 years ago by Garry Yao (previous) (diff)

comment:4 Changed 7 years ago by Olek Nowodziński

Status: review_failedreview

comment:5 Changed 7 years ago by Garry Yao

Status: reviewreview_passed

comment:6 Changed 7 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy