Opened 10 years ago
Closed 10 years ago
#9621 closed Bug (fixed)
No focus style for disabled buttons
| Reported by: | Frederico Caldeira Knabben | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.0 |
| Component: | UI : Skins | Version: | 4.0 |
| Keywords: | Cc: |
Description
Unlike v3, v4 doesn't have any styling for disabled buttons on the toolbar:
- Put the focus in the editor.
- ALT+F10 to focus the toolbar.
- TAB to move to any toolbar group with disabled icons.
- ARROW-RIGHT to move among the buttons.
Note that the disable buttons have no style, so the focus gets visibly lost.
Disabled buttons should simply use the background styles used on hover of enabled buttons when they have focus.
Change History (6)
comment:1 Changed 10 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | new → assigned |
comment:2 Changed 10 years ago by
| Status: | assigned → review |
|---|
comment:3 Changed 10 years ago by
| Status: | review → review_failed |
|---|
- Hover style is still missing
- High-contrast is not affected by this fix.
Pushed the fix for that 50a0ef7799 (No focus style for disabled buttons.)
comment:4 Changed 10 years ago by
| Status: | review_failed → review |
|---|
comment:5 Changed 10 years ago by
| Status: | review → review_passed |
|---|
comment:6 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Note: See
TracTickets for help on using
tickets.
Created t/9621@cksource with a fix.