Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#9633 closed Bug (fixed)

New icon for placeholder

Reported by: Piotrek Koszuliński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.0
Component: UI : Skins Version: 4.0
Keywords: Cc: Teresa Monahan

Description

There's a question also - why currently we've got two placehoder icons? createplaceholder and editplaceholder?

Change History (8)

comment:1 Changed 7 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: newassigned

comment:2 Changed 7 years ago by Olek Nowodziński

I pushed the new icon to t/9633@cksource. I won't put it on review until createplaceholder/editplaceholder issue is unclear.

comment:3 Changed 7 years ago by Piotrek Koszuliński

There are two icons because we have two commands. One, used in toolbar, second, in context menu. Now it should be possible to reuse the same icon - check https://github.com/ckeditor/ckeditor-dev/commit/87d2fceaef9d8fbb0c5ae95a229a978fb1aa654a.

comment:4 Changed 7 years ago by Piotrek Koszuliński

BTW. You can put this icon in plugins/placeholder/icons, because soon (#9626) the rest will be moved from skin to plugins.

comment:5 Changed 7 years ago by Olek Nowodziński

Status: assignedreview
  • Ported #9555 feature to menu plugin. It's possible to customize menus in the same way.
  • Merged createplaceholder.png and editplaceholder.png icons so placeholder.png is used for both commands.
Last edited 7 years ago by Olek Nowodziński (previous) (diff)

comment:6 Changed 7 years ago by Piotrek Koszuliński

Cc: Teresa Monahan added
Status: reviewreview_passed

R+.

CCing tmonahan, because under #9555 she asked for enabling this feature for menu items.

comment:7 Changed 7 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

comment:8 in reply to:  6 Changed 7 years ago by Teresa Monahan

Replying to Reinmar:

R+.

CCing tmonahan, because under #9555 she asked for enabling this feature for menu items.

Thanks for enabling this feature for menu items and for notifying me about it. Much appreciated!

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy