#9633 closed Bug (fixed)
New icon for placeholder
Reported by: | Piotrek Koszuliński | Owned by: | Olek Nowodziński |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.0 |
Component: | UI : Skins | Version: | 4.0 |
Keywords: | Cc: | Teresa Monahan |
Description
There's a question also - why currently we've got two placehoder icons? createplaceholder and editplaceholder?
Change History (8)
comment:1 Changed 8 years ago by
Owner: | set to Olek Nowodziński |
---|---|
Status: | new → assigned |
comment:2 Changed 8 years ago by
comment:3 Changed 8 years ago by
There are two icons because we have two commands. One, used in toolbar, second, in context menu. Now it should be possible to reuse the same icon - check https://github.com/ckeditor/ckeditor-dev/commit/87d2fceaef9d8fbb0c5ae95a229a978fb1aa654a.
comment:4 Changed 8 years ago by
BTW. You can put this icon in plugins/placeholder/icons, because soon (#9626) the rest will be moved from skin to plugins.
comment:5 Changed 8 years ago by
Status: | assigned → review |
---|
- Ported #9555 feature to menu plugin. It's possible to customize menus in the same way.
- Merged
createplaceholder.png
andeditplaceholder.png
icons soplaceholder.png
is used for both commands.
comment:6 follow-up: 8 Changed 8 years ago by
Cc: | Teresa Monahan added |
---|---|
Status: | review → review_passed |
R+.
CCing tmonahan, because under #9555 she asked for enabling this feature for menu items.
comment:7 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
I pushed the new icon to t/9633@cksource. I won't put it on review until createplaceholder/editplaceholder issue is unclear.