New icon for placeholder

[Piotrek Koszuliński]

There's a question also - why currently we've got two placehoder icons? createplaceholder and editplaceholder?

[Olek Nowodziński]

I pushed the new icon to t/9633@cksource. I won't put it on review until createplaceholder/editplaceholder issue is unclear.

[Piotrek Koszuliński]

There are two icons because we have two commands. One, used in toolbar, second, in context menu. Now it should be possible to reuse the same icon - check ​https://github.com/ckeditor/ckeditor-dev/commit/87d2fceaef9d8fbb0c5ae95a229a978fb1aa654a.

[Piotrek Koszuliński]

BTW. You can put this icon in plugins/placeholder/icons, because soon (#9626) the rest will be moved from skin to plugins.

[Olek Nowodziński]

• Ported #9555 feature to menu plugin. It's possible to customize menus in the same way.
• Merged createplaceholder.png and editplaceholder.png icons so placeholder.png is used for both commands.

[Piotrek Koszuliński]

R+.

CCing tmonahan, because under #9555 she asked for enabling this feature for menu items.

[Piotrek Koszuliński]

Masterised ​https://github.com/ckeditor/ckeditor-dev/commit/3592a8e

[Teresa Monahan]

Replying to Reinmar:

R+.

CCing tmonahan, because under #9555 she asked for enabling this feature for menu items.

Thanks for enabling this feature for menu items and for notifying me about it. Much appreciated!