Opened 7 years ago

Closed 7 years ago

#9669 closed Bug (fixed)

Concerns regarding new contents.css

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.0
Component: Documentation & Samples Version: 4.0
Keywords: Cc:

Description

The following compatibility issues are found regard the new blockquote style:

  • Not compatible in RTL content
  • Not compatible with showblocks comman

Attachments (2)

bqrtlltr.png (112.0 KB) - added by Olek Nowodziński 7 years ago.
bqinlinertl.png (25.8 KB) - added by Olek Nowodziński 7 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: newassigned

comment:2 Changed 7 years ago by Olek Nowodziński

Status: assignedreview

Pushed fix to t/9669@cksource. Fixed bad blockquote border in RTL.

I don't find showblocks issue, namely disappearing blockquote border, a real issue since showblocks isn't for eyecandy but for observing document's structure.

comment:3 Changed 7 years ago by Piotrek Koszuliński

Status: reviewreview_failed

No margins symmetry in RTL vs LTR. In LTR there's small left margin, in RTL big right. They should be equal.

comment:4 Changed 7 years ago by Piotrek Koszuliński

PS. I also don't find missing border in showblocks mode an issue.

Changed 7 years ago by Olek Nowodziński

Attachment: bqrtlltr.png added

Changed 7 years ago by Olek Nowodziński

Attachment: bqinlinertl.png added

comment:5 Changed 7 years ago by Piotrek Koszuliński

Status: review_failedreview_passed

Ok, I was wrong about these margins :| I still think they are different, but evidences show something else ;< I've lost.

comment:6 Changed 7 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Merged into master with git:a3e65c2

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy