Opened 12 years ago
Closed 12 years ago
#9721 closed Bug (fixed)
Padding in content of div based editor puts editing area under bottom UI space
| Reported by: | Piotrek Koszuliński | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.0.1 |
| Component: | General | Version: | 4.0 |
| Keywords: | Cc: |
Description (last modified by )
See screenshot of http://ckeditor.com/demo#div
Attachments (3)
Change History (11)
Changed 12 years ago by
| Attachment: | div-editor-padding.png added |
|---|
comment:1 Changed 12 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 12 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | new → review |
comment:3 Changed 12 years ago by
| Status: | review → review_failed |
|---|
Unfortunately, IE7 doesn't support box-sizing:
Changed 12 years ago by
| Attachment: | box-sizing-ie7.png added |
|---|
comment:4 Changed 12 years ago by
| Owner: | changed from Garry Yao to Olek Nowodziński |
|---|---|
| Status: | review_failed → assigned |
comment:5 Changed 12 years ago by
| Status: | assigned → review |
|---|
comment:6 Changed 12 years ago by
| Status: | review → review_failed |
|---|
Unfortunately scrollbar on IE7@divarea sample behaves strangely.
comment:7 Changed 12 years ago by
| Status: | review_failed → review |
|---|
Pushed another solution to t/9721c, which solves IE7 issue with pseudo-expression code in divarea plugin. Since there's no single IE expression in editor CSS, I decided to not to pollute it and ported it into editor code.
Such JS solution (instead of CSS expression), however, brings safety concerns. For example, it can be violated by omitting relevant editor events. If possible, I'd suggest to use CSS expression or create a wrapper for .cke_wysiwyg_div or force-reset padding in IE7 (ugly idea).
The solution is based on the blog article.
comment:8 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
We couldn't find any safe pure-CSS patch for IE7 so based on a fact that P(IE7) * P(divarea) is extremely low we decided to gracefully degrade in this case by resetting vertical paddings to 0px.
Fixed on master with git:c824c5d.
Opened review e3ef009.