Changes between Initial Version and Version 6 of Ticket #9779


Ignore:
Timestamp:
Feb 6, 2013, 11:39:45 AM (12 years ago)
Author:
Frederico Caldeira Knabben
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #9779

    • Property Status changed from new to confirmed
    • Property Milestone changed from to CKEditor 4.0.2

  • Ticket #9779 – Description

    initial v6  
    1 in previous version you could override geturl by creating a function called
     1In previous version you could override geturl by creating a function called CKEDITOR_GETURL. This seems be broken because of this block in ckeditor_base.js:
    22
    3 CKEDITOR_GETURL
     3{{{
     4// Make it possible to override the "url" function with a custom
     5// implementation pointing to a global named CKEDITOR_GETURL.
     6var newGetUrl = window.CKEDITOR_GETURL;
     7if ( newGetUrl ) {
     8        var originalGetUrl = CKEDITOR.url;
     9        CKEDITOR.url = function( resource ) {
     10                return newGetUrl.call( CKEDITOR, resource ) || originalGetUrl.call( CKEDITOR, resource );
     11        };
     12}
     13}}}
    414
    5 this seems be broken because of this block in ckeditor_base.js
     15It should be:
    616
     17{{{
    718// Make it possible to override the "url" function with a custom
    8                 // implementation pointing to a global named CKEDITOR_GETURL.
    9                 var newGetUrl = window.CKEDITOR_GETURL;
    10                 if ( newGetUrl ) {
    11                         var originalGetUrl = CKEDITOR.url;
    12                         CKEDITOR.url = function( resource ) {
    13                                 return newGetUrl.call( CKEDITOR, resource ) || originalGetUrl.call( CKEDITOR, resource );
    14                         };
    15                 }
    16 
    17 it should be
    18 
    19 // Make it possible to override the "url" function with a custom
    20                 // implementation pointing to a global named CKEDITOR_GETURL.
    21                 var newGetUrl = window.CKEDITOR_GETURL;
    22                 if ( newGetUrl ) {
    23                         var originalGetUrl = CKEDITOR.getUrl;
    24                         CKEDITOR.getUrl = function( resource ) {
    25                                 return newGetUrl.call( CKEDITOR, resource ) || originalGetUrl.call( CKEDITOR, resource );
    26                         };
    27                 }
    28 
     19// implementation pointing to a global named CKEDITOR_GETURL.
     20var newGetUrl = window.CKEDITOR_GETURL;
     21if ( newGetUrl ) {
     22        var originalGetUrl = CKEDITOR.getUrl;
     23        CKEDITOR.getUrl = function( resource ) {
     24                return newGetUrl.call( CKEDITOR, resource ) || originalGetUrl.call( CKEDITOR, resource );
     25        };
     26}
     27}}}
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy