Opened 6 years ago

Closed 3 years ago

#9856 closed Bug (fixed)

Divarea breaks native context menu

Reported by: Bernhard Frauendienst Owned by:
Priority: Normal Milestone: CKEditor 4.5.4
Component: General Version: 4.0 Beta
Keywords: Cc: scott@…, mark@…

Description

When using the divarea plugin, the native contextmenu no longer works on the content space.

This is caused by the following constellation:

  • disableContextMenu is called on the browser chrome
  • events from the divarea content bubble up to the browser chrome (as opposed to the regular iframe solution)
  • => preventDefault is called on the contextmenu event in most cases, preventing the context menu to show up

One solution could be to modify the disableContextMenu listener function to also check for of event target ancestors with the cke_enable_context_menu class, this would make the handler less performant though. Another solution could be to prevent the contextmenu event from bubbling up the contents space, which is what I have used for now as a workaround.

Change History (11)

comment:1 Changed 6 years ago by Jakub Ś

Status: newconfirmed
Version: 4.04.0 Beta

If you remove editor menu with removePlugins : 'liststyle,tabletools,contextmenu' you will not get anything on right click.

This problem can be reproduced in all browsers, only in divarea (iframe and inline editing work fine) from CKE 4 beta.

comment:2 Changed 5 years ago by Jakub Ś

#11476 was marked as duplicate - config.browserContextMenuOnCtrl doesn't help or wor either.

comment:3 Changed 5 years ago by Jakub Ś

#11509 was marked as duplicate.

comment:4 Changed 5 years ago by Scott Nelson

Cc: scott@… added

comment:5 Changed 4 years ago by Jonathan

Following this issue.

comment:6 Changed 3 years ago by Mark Wade

Cc: mark@… added

Is there likely to be any progress on this issue soon?

comment:7 Changed 3 years ago by Mark Wade

comment:8 Changed 3 years ago by Piotrek Koszuliński

The PR isn't unfortunately correct, but I commented with some more details how a patch and its tests could look like.

comment:9 Changed 3 years ago by Piotrek Koszuliński

Summary: divarea breaks native context menuDivarea breaks native context menu

comment:10 Changed 3 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.5.4

Fixed on master with git:dc88a6c and git:b4effd4 thanks to the pull request.

comment:11 Changed 3 years ago by Piotrek Koszuliński

Resolution: fixed
Status: confirmedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy