Opened 14 years ago

Closed 14 years ago

#9907 closed New Feature (fixed)

Add ability to process data that goes to preview

Reported by: Piotrek Koszuliński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.1 RC
Component: General Version: 3.0
Keywords: Cc:

Description

Change History (12)

comment:1 Changed 14 years ago by Jakub Ś

Status: new → confirmed

comment:2 Changed 14 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: confirmed → assigned

comment:3 Changed 14 years ago by Olek Nowodziński

Status: assigned → review

Added contentPreview event in ​t/9907@cksource with basic dt in t/9907@tests-v4.

To alter all occurrences of "Apollo" with "Gemini" in the preview of replacebycode sample's content, basically do the following:

CKEDITOR.replace( 'editor1', {
	on: {
		contentPreview: function( event ) {
			event.data.dataValue = event.data.dataValue.replace( /Apollo/g, 'Gemini' );
		}
	}
} );

comment:4 Changed 14 years ago by Frederico Caldeira Knabben

Status: review → review_passed

comment:5 Changed 14 years ago by Olek Nowodziński

Resolution: → fixed
Status: review_passed → closed

Feature added to major in commit ​git:2ae48b9

Tests pushed to major with 5866ffd@tests-v4.

comment:6 Changed 14 years ago by Piotrek Koszuliński

Isn't it possible to close preview window on test tear down or block it somehow? It stays opened when running tests suite and I'm anticipating unwelcome surprises :D

comment:7 Changed 14 years ago by Olek Nowodziński

Resolution: fixed
Status: closed → reopened

comment:8 in reply to:  6 Changed 14 years ago by Olek Nowodziński

Replying to Reinmar:

Isn't it possible to close preview window on test tear down or block it somehow? It stays opened when running tests suite and I'm anticipating unwelcome surprises :D

Reopening the ticket to fix this issue.

comment:9 Changed 14 years ago by Jakub Ś

Status: reopened → confirmed

comment:10 Changed 14 years ago by Olek Nowodziński

Status: confirmed → review

Created ​t/9907b@cksource + t/9907b@tests-v4.

Added possibility to prevent preview window from being open via contentPreview event. Used this feature to fix tests: no annoying popups anymore.

comment:11 Changed 14 years ago by Frederico Caldeira Knabben

Status: review → review_passed

comment:12 Changed 14 years ago by Olek Nowodziński

Resolution: → fixed
Status: review_passed → closed

Fixed popup issue in ​git:3e347c8687 (major) (tests: 4eb7762).

Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy