insertcellbefore and insertcellafter in nested tables is incorrect

[Michiel Overeem]

The insertcellbefore and insertcellafter commands from the tabletools plugin is incorrect. The insertCell function found in this plugin looks for the first tablecell (td) ascendant. If there is none, it looks for the first table-header-cell (th) ascendant. It does not check if the cell is a child of the current table. If the tables are nested, or the editor itself is nested inside of a table, the cell is added to the incorrect table. I've attached a corrected function that can be used to patch this bug.

[Michiel Overeem]

corrected insertCell function

[Michiel Overeem]

Sample file to illustrate the problem

[Michiel Overeem]

Attached is a sample file to show the problem. Inserting a cell from the contextmenu in the first cell ('header one') inserts the cell in the outer table, which is not part of the contenteditable element. Inserting in the cells on row two ('cell one' and 'cell two') works correct.

[Michiel Overeem]

The same problem is present in the getSelectedCells function inside the plugin.

[Jakub Ś]

1. Problem can be reproduced from CKEditor 3.0 in both 3.x and 4.x.
2. Just put cursor in header cell and select insert cell before or after

Result: Cell will be inserted in outer table

The same thing can be reproduced with iframed editor with below code:

<table border="1" cellpadding="1" cellspacing="1" style="width: 500px;">
	<tbody>
		<tr>
			<td>
				&nbsp;</td>
			<td>
				<p>
					&nbsp;</p>
				<p>
					&nbsp;</p>
				<table border="1" cellpadding="1" cellspacing="1" style="width: 500px;">
					<thead>
						<tr>
							<th scope="col">
								&nbsp;</th>
							<th scope="col">
								&nbsp;</th>
						</tr>
					</thead>
					<tbody>
						<tr>
							<td>
								&nbsp;</td>
							<td>
								&nbsp;</td>
						</tr>
					</tbody>
				</table>
				<p>
					&nbsp;</p>
			</td>
			<td>
				&nbsp;</td>
		</tr>
	</tbody>
</table>

[Jakub Ś]

@michielovereem - To get your proposed fix tested and applied (if it is correct) please fork CKEditor 4 code from ​https://github.com/ckeditor/ckeditor-dev, prepare your fix and make a "pull request" (here is the example list of pull requests ​https://github.com/ckeditor/ckeditor-dev/pulls?direction=desc&page=1&sort=created&state=open). In comment please specify link to bug for which this fix was prepared. This is much faster way to get proposed fix implemented/rejected (if they are invalid). At least in V4.

In CKEditor 3.x we go through proposed SVN patches every couple of weeks (sometimes moths) and decide whether to apply them or not. This of course takes more time then pull requests on github but this is what versioning system offered and we had to adjust to it.

[Michiel Overeem]

Added pull request with the required fix: ​https://github.com/ckeditor/ckeditor-dev/pull/36

[Jakub Ś]

This is a duplicate of #11192. @michielovereem I will move your pull request there.