InsertHtml() ignores current selection in IE. Again.
|Reported by:||MarkWB||Owned by:||martinkou|
|Component:||UI : Dialogs||Version:||SVN (FCKeditor) - Retired|
|Keywords:||Confirmed IE Review+||Cc:|
I hate to be a pest about the same thing over and over again, but the bug as reported in #1990 is back as originally stated for both 2.6 and the SVN.
For whatever reason, the condition put in place to fix #2057, which was the fix for the flashing problem of the fix for #1990, that detects whether the selection has already been restored is always true when running the simple plugin attached to #1990. Therefore, the selection never does get restored hence why the original #1990 problem.
Perhaps the logic implemented by #2057 will only work if the EditorDocument doesn't have focus. This is my guess because if I rearrange lines 152 thru 155 in the InsertHtml function of 'fck_ie.js' such that FCKUndo.SaveUndoStep() happens before setting focus:
FCKUndo.SaveUndoStep() ; // FCK.Focus() ; FCK.EditorWindow.focus() ;
that seems to fix it. Perhaps logic of #2057 should be reviewed if needed for other broken circumstances. Putting that save undo call before the InsertHtml() call in the plugin also works around it. (What fun could you have without IE?)
FYI... The FCKSelection.Restore() function gets called a lot, even when there is no active dialog. Not much can be done with the editor per 100 times this gets called. However, the call rate gets drastically reduced after a positive response (e.g. OK button) to a dialog.
Change History (9)
comment:1 Changed 8 years ago by martinkou
- Keywords Confirmed IE added
- Owner set to martinkou
- Status changed from new to assigned
Changed 8 years ago by martinkou
comment:4 Changed 8 years ago by alfonsoml
- Summary changed from The #1990 bug is back again. to InsertHtml() ignores current selection in IE. Again.
Changed 8 years ago by alfonsoml
comment:6 Changed 8 years ago by martinkou
- Resolution set to fixed
- Status changed from assigned to closed