[IE] Editing image with keyboard does not retain the properties of the image when displaying the image dialog

[Damian]

To reproduce:

1. Insert an image using the image dialog
2. Using the keyboard, highlight the image
3. Select the image action from the context or toolbar

Result: the image properties are not populated in the image dialog

Expected result: the dialog should be populated with the image's properties.

Note: using the mouse to select the image, does work as expected.

Tested on IE 6 & 7

[Garry Yao]

Note that the problem not only affect all IE versions, but also influence Firefox and other browsers, it should be considered as major defect for accessibility.

[Garry Yao]

The buggy thing is about the way we've used to figure out selected element in editor:

selection.getStartElement();		// Are you kidding?
selection.getSelectedElement();			// Maybe?
selection.getRanges()[0].getEnclosedNode();		// Closer?

Proposing a patch that bring more robust implementation to selection::getSelectedElement. Note that the patch includes part of the changes been proposed at #4513, which is similar to this problem.

[Alfonso Martínez de Lizarrondo]

In dom/range.js:
There are three "if( " instead of "if ( "

The "if( this.collapsed )" doesn't need an else clause, you can put all the following code at the same level due to the return when it's true. You can then move the

    !mode && ( mode = CKEDITOR.SHRINK_TEXT ); 

after that line if you want.

And you can put the moveStart, moveEnd and currentElement declarations at the 1259 line

In selection/plugin.js: does it needs the

else 
    throw '';

part?

I would put the

var node = 
 	CKEDITOR.tools.tryThese( 

part in a single line.

[Alfonso Martínez de Lizarrondo]

The patch also fixes #2570

[Garry Yao]

Please leave the review role of this ticket to Fred.

[Frederico Caldeira Knabben]

Please be sure to have design tests in place for the shrink function.

[Garry Yao]

Fixed with [5254] and [5255] and [5256].