Opened 15 years ago
Closed 15 years ago
#5553 closed Bug (fixed)
Cursor location in Paste from Word and Paste dialogs is incorrect for BIDI languages
Reported by: | Satya Minnekanti | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.3 |
Component: | UI : Language | Version: | 3.0 |
Keywords: | IBM Confirmed Review+ | Cc: | Damian, joek |
Description
To reproduce the defect:
- Select Arabic or Hebrew in the languages drop don list
- Click on Paste from Word or Paste Icons in the Toolbar
Expected Result: Paste from Word or Paste dialog is opened and the Cursor is on the right-side of the text area
Actual Result: Paste from Word or Paste dialog is opened and the Cursor is on the left-side of the text area.
The Cursor Position is shown properly in Paste as Plain Text dialog.
Attachments (4)
Change History (21)
Changed 15 years ago by
Attachment: | 5553.patch added |
---|
comment:1 Changed 15 years ago by
Keywords: | Confirmed Review? added |
---|---|
Owner: | set to Garry Yao |
Status: | new → assigned |
Version: | 3.2 → 3.0 |
comment:2 Changed 15 years ago by
Component: | General → UI : Language |
---|---|
Keywords: | Review- added; Review? removed |
comment:3 Changed 15 years ago by
#5485 is introducing the contentLanguage setting which could be then used for the "lang" attribute.
comment:4 Changed 15 years ago by
Matches my first thought on this, but does that means we should reflect the same thing to Paste Text dialog?
Changed 15 years ago by
Attachment: | 5553_2.patch added |
---|
comment:5 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:6 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:8 Changed 15 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
This is still not fixed..Cursor is still showing on the left hand side of Text Area in Paste and Paste from Word dialogs.
comment:9 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Now the paste area behaves just like editing document, explicit definition of 'contentsLangDirection' is required if you're using a ltr UI language.
comment:10 Changed 15 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
There is still an inconsistency here. The textarea in the Paste Text dialog is taking the language direction from the UI, it should now use the contentsLangDirection instead.
Changed 15 years ago by
Attachment: | 5553_3.patch added |
---|
comment:11 Changed 15 years ago by
Keywords: | Review? added; Review+ removed |
---|
Align the 'Paste Text' area direction.
comment:12 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
The documentation changes may not be needed though, as the pasting area is in fact related to the contents, so it simply inherits its direction (it may happen in other parts of the editor, even if not documented).
comment:14 Changed 15 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
This still doesn't seem to work for Paste as Plain Text. I can see that the following code is in the dialog:
'dir=' + editor.config.contentsLangDirection + ';' +
but the output HTML does not use the 'dir' property?
Changed 15 years ago by
Attachment: | 5554_4.patch added |
---|
comment:15 Changed 15 years ago by
Keywords: | Review? added; Review+ removed |
---|
The patch used the "dir=" attribute instead of the css "direction:"
comment:16 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
Considering that the pasting area is there to receive contents to be inputted in the editor, I think the contentsLangDirection setting should be used instead. In that case, the "lang" attribute cannot be used as we don't have such information.