Opened 6 years ago

Closed 6 years ago

#6058 closed Bug (fixed)

[IE Quirks] CSS-Glitch with file upload fields

Reported by: comp615 Owned by: fredck
Priority: Normal Milestone: CKEditor 3.4
Component: UI : Skins Version: SVN (CKEditor) - OLD
Keywords: IE HasPatch Cc:

Description

Under IE-Quirks mode, the file upload fields are too small. This stems from what appears to be a mis-named CSS tag.

Attachments (4)

6058.patch (1.0 KB) - added by comp615 6 years ago.
Removed superflous iframe, to simply target the class instead (As originally intended I assume)
current_code.JPG (19.7 KB) - added by comp615 6 years ago.
Ok attaching pics, those always help.
patched_code.JPG (17.3 KB) - added by comp615 6 years ago.
Ok attaching pics, those always help.
6058_2.patch (1.2 KB) - added by fredck 6 years ago.

Download all attachments as: .zip

Change History (13)

Changed 6 years ago by comp615

Removed superflous iframe, to simply target the class instead (As originally intended I assume)

comment:1 Changed 6 years ago by fredck

  • Status changed from new to pending

I'm trying it with IE8+Quirks and it works well for me. In fact, your patch makes no difference.

Can you give us more information about your browser versions? Maybe a screenshot of the issue?

Btw, please always produce patches form the project root (trunk or specific branch), so we can just apply it directly to the root also. Thanks!

Changed 6 years ago by comp615

Ok attaching pics, those always help.

Changed 6 years ago by comp615

Ok attaching pics, those always help.

comment:2 Changed 6 years ago by comp615

Browser is IE 8.0.6001 on WinXP. I was able to re-produce under both 7/8 mode with Quirks on and IE7 on another computer (I think he has quirks on too).

comment:3 follow-up: Changed 6 years ago by comp615

Also, since I can't figure out how to contact you on the forums, I have to ask for help figuring out what I'm doing wrong when making patches here.

I use TortiseSVN and have set a folder to http://svn.ckeditor.com/CKEditor/trunk which is trunk right?

Then I hit Update SVN, to get the latest stuff. Make my changes, test, then hit create patch and save it. Perhaps it's actually compiled against trunk, but shows the last revision where that file was changed? Is there a way to change this?

comment:4 in reply to: ↑ 3 Changed 6 years ago by fredck

Replying to comp615:

Perhaps it's actually compiled against trunk, but shows the last revision where that file was changed? Is there a way to change this?

As long as you're right-clicking on your local trunk root folder when creating the patch, that should be ok. But it looks like, for this specific case, you have clicked the _source/skin folder instead, so the patch will be relative to that patch.

Changed 6 years ago by fredck

comment:5 Changed 6 years ago by fredck

  • Owner set to fredck
  • Status changed from pending to review

Ok, my Window styles are a bit different, and this may be the case.

In any case, the change should have no drawback, so I'm trusting your tests there to accept it. I'm just targeting it to the 3.4.x branch, just to be sure.

comment:6 Changed 6 years ago by comp615

Ok thanks. Yes I found no drawbacks testing in FF, IE, and Chrome. From a code standpoint I don't see any drawbacks either (Unless someone had an upload box in an iframe somehow) :-P

comment:7 Changed 6 years ago by fredck

  • Milestone set to CKEditor 3.4

comment:8 Changed 6 years ago by Saare

  • Status changed from review to review_passed

comment:9 Changed 6 years ago by fredck

  • Resolution set to fixed
  • Status changed from review_passed to closed

Fixed with [5774].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy