Opened 6 years ago

Closed 6 years ago

#10097 closed Bug (fixed)

JSLint issues to be fixed

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.1 RC
Component: General Version: 4.0.2
Keywords: Cc:

Description

(major=db6ffc3) oleq@pc ~/ck/ckeditor-dev> dev/jslint/linter 
~/ck/ckeditor-dev/dev/jslint ~/ck/ckeditor-dev
/home/oleq/ck/ckeditor-dev/core/filter.js(208): SyntaxError: invalid quantifier {
					else if ( el.type == CKEDITOR.NODE_COMMENT && el.value.match( /^{cke_protected}(?!{C})/ ) ) {
......................................................................................................^

/home/oleq/ck/ckeditor-dev/core/htmldataprocessor.js(158): lint warning: missing semicolon
			if ( !context && context !== null )
........................^

/home/oleq/ck/ckeditor-dev/core/htmlparser/comment.js(62): warning: anonymous function does not always return a value
	},
........^

/home/oleq/ck/ckeditor-dev/core/htmlparser/element.js(199): warning: anonymous function does not always return a value
					return;
..............................................^

/home/oleq/ck/ckeditor-dev/core/htmlparser/element.js(206): warning: anonymous function does not always return a value
					return false;
....................................................^

/home/oleq/ck/ckeditor-dev/core/htmlparser/element.js(243): warning: anonymous function does not always return a value
		},
................^

/home/oleq/ck/ckeditor-dev/plugins/preview/plugin.js(98): warning: anonymous function does not always return a value
		}
................^

/home/oleq/ck/ckeditor-dev/plugins/stylescombo/plugin.js(180): lint warning: undeclared identifier: loadStylesSet
/home/oleq/ck/ckeditor-dev/plugins/format/plugin.js(35): lint warning: comparisons against null, 0, true, false, or an empty string allowing implicit type conversion (use === or !==)
		if ( stylesCount == 0 )
......................................^


1 error(s), 8 warning(s)
~/ck/ckeditor-dev

Seek and destroy.

Change History (4)

comment:1 Changed 6 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: newassigned

comment:2 Changed 6 years ago by Olek Nowodziński

Status: assignedreview

Created branch t/10097@cksource with JSLint fixes.

Note: needs careful review even though tests say OK. Modified regular expressions and returned values of filter sub-methods.

comment:3 Changed 6 years ago by Piotrek Koszuliński

Status: reviewreview_passed

I pushed one more tiny fix. The rest is ok.

comment:4 Changed 6 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Changes merged into major in git:69dcd98f4b.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy