Opened 13 years ago
Closed 13 years ago
#10137 closed Bug (fixed)
Empty Syles combo in filter sample
| Reported by: | Olek Nowodziński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.1 RC |
| Component: | Core : Styles | Version: | 4.0.2 |
| Keywords: | Cc: |
Description
- http://ckeditor4.t/ckeditor/samples/filter.html
- See Styles combos of editor 2 & 3: they're empty.
- This looks like:
Change History (7)
comment:1 Changed 13 years ago by
| Status: | new → confirmed |
|---|
comment:2 Changed 13 years ago by
Not a bug - feature. Combo is empty, because all styles available for current selection are disallowed by ACF. Select image and you'll see image's styles there.
But the issue still exists. To avoid confusion like yours we may add more rules for these editors.
comment:3 Changed 13 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | confirmed → assigned |
comment:4 Changed 13 years ago by
| Status: | assigned → review |
|---|
Created branch t/10137:
- Created custom stylesSet for this sample so no stylescombos are empty.
- Removed unnecessary "editor 5" that was for testing purposes only and didn't reflect any filtering feature.
comment:5 Changed 13 years ago by
| Owner: | changed from Olek Nowodziński to Piotrek Koszuliński |
|---|
We don't need to set special styles set for filter sample. Default one is ok. Less changes make sample less confusing.
I pushed t/10137b which:
- adds ACRs for 2nd and 3rd editors which enable some of the default styles,
- removes editor5 which indeed is unnecessary - next one (based on h1 editable) is much better.
comment:6 Changed 13 years ago by
| Status: | review → review_passed |
|---|
comment:7 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed on major with git:516399f.


To reproduce: