Opened 7 years ago

Closed 7 years ago

#10138 closed Bug (fixed)

Bottom spaces don't work for inline editors in sharedspace sample

Reported by: Olek Nowodziński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.1 RC
Component: General Version: 4.0.2
Keywords: Cc:

Description

  1. Go to sharedspace sample.
  2. Play with elementspath. It neither display current path for inline instance nor selects element when clicked.

Change History (5)

comment:1 Changed 7 years ago by Piotrek Koszuliński

Status: newconfirmed

Elements path is switched off for inline editors (plugins.js:60-62). When adding this check I didn't thought that shared spaces will be introduced. Now it has to be corrected - elements path shouldn't be initialized when it won't be displayed.

Last edited 7 years ago by Piotrek Koszuliński (previous) (diff)

comment:2 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 4.1

comment:3 Changed 7 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.1
Owner: set to Piotrek Koszuliński
Status: confirmedreview

Pushed t/10138 with simple fix - initialize elements path exactly on editor#uiSpace, not on plugin #init.

comment:4 Changed 7 years ago by Olek Nowodziński

Status: reviewreview_passed

comment:5 Changed 7 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Fixed on major with git:065c024.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy