Opened 6 years ago

Closed 6 years ago

#10152 closed Bug (fixed)

Invalid ARIA property used on menu items

Reported by: Teresa Monahan Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 4.0.2
Component: Accessibility Version: 4.0.2
Keywords: IBM Cc: Damian, Satya Minnekanti

Description

Menu items in CKEditor 4.x have an invalid WAI-ARIA attribute applied: aria-pressed

This is not a valid attribute for elements with a menuitem role as specified in http://www.w3.org/TR/wai-aria/roles#menuitem.

<a ....aria-pressed="false" .... role="menuitem" ... class="cke_menubutton cke_menubutton__paste cke_menubutton_off cke_menubutton__paste" >...</a>

This is a failure of WCAG 2.0 checkpoint 4.1.2. See details at: http://www.w3.org/TR/2012/NOTE-UNDERSTANDING-WCAG20-20120103/ensure-compat-rsv.html

Change History (4)

comment:1 Changed 6 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 4.1.1

comment:2 Changed 6 years ago by Frederico Caldeira Knabben

Owner: set to Frederico Caldeira Knabben
Status: newreview

Pushed t/10152@cksource.

In fact, it looks like this attribute has been inherited from toolbar buttons, but is not effectively in use in menu lists, even if it has the potential for being useful. Still, the right way for having it is by using the "menuitemcheckbox" role.

Anyway, there is no plugin counting on this feature, so we can safely simply remove the attribute.

comment:3 Changed 6 years ago by Olek Nowodziński

Milestone: CKEditor 4.1.1CKEditor 4.0.2
Status: reviewreview_passed

comment:4 Changed 6 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Merged git:6bf40ac800. This fix will be included in the upcoming CKEditor 4.0.2

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy