Opened 5 years ago

Last modified 5 years ago

#10159 confirmed Bug

Sourcedialog and Sourcearea plugins - better interoperability needed?

Reported by: Wiktor Walc Owned by:
Priority: Normal Milestone:
Component: General Version: 4.1 RC
Keywords: Cc:

Description

The new sourcedialog plugin introduced a new button name for a feature that already exists - editing source code. I think it is wrong because of various reasons.

1. Do not use different button names

(i) Noone would like to have enabled both "Source" buttons in the toolbar at the same time. The only purpose of both plugins is to edit source code (that's why even the buttons looks the same).

Why user may want to use both plugins? Let's look at the case of Drupal: there is a framed editor in the administration area and inline editor in another place. So it needs both plugins (unless the sourcedialog will be used in each case, however some may prefer the sourcearea plugin and use sourcedialog just as a fallback solution.

(ii) Once user realize that he has two buttons in some samples (after downloading a custom package), he'll have to start digging how to change the toolbar configuration to get rid of one button. And then, deal everywhere with toolbar configurations or removePlugins/extraPlugins and so on.

* Unless we configure online builder to allow adding just one plugin of this kind.

2. sourcedialog could be shipped in std/full package

Currently, because of a "toolbar conflict" between both plugins, we cannot have both enabled in default packages (at least without adding code to other samples to handle both plugins at once). If we ensure that both plugins can be enabled at once and that duplicated buttons will not appear, that would be cool, because for example the inline/sharedspace samples could show this button.

There is so many samples, that it is still hard to say whether CKEditor supports source editing in inline mode, by looking at promoted inline samples at the top where the "Source" button is missing.

This is the main reason why I think it would be better if plugins could somehow cooperate, to be able to use source editing in inline mode without any extra effort. If enabling the "Source" button in inline environment would require from user 0 additional steps that would be quite awesome.

3. sourcedialog for inline editing sourcearea for framed mode?

If both plugins are enabled, we could make the plugins a bit more smart: let the sourcearea plugin work in framed environment and enable the source dialog plugin in environment not supported by sourcearea. Again, a single button name would be used for the toolbar configuration.

Change History (1)

comment:1 Changed 5 years ago by Jakub Ś

Status: newconfirmed

I agree having 2 identical buttons doing almost the same is a little bit weird.

NOTES:

  1. If making plugins cooperate is impossible then perhaps this could be configured with some config option having values: contentArea, sourceDialog and both as there probably will be users who will want to use both plugins at once.
  2. If making plugins cooperate is impossible then perhaps making a little bit different icon for source dialog isn't bad idea.
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy