Opened 12 years ago
Last modified 12 years ago
#10185 confirmed New Feature
Placeholder is not configurable
Reported by: | Philipp Holz | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | Core : Output Data | Version: | |
Keywords: | Cc: |
Description
At the moment it is not possible to change the placeholder that is used. So I made it optional configurable via the editor config. Default is still content ?. Due to placeholder is a core plugin i thought its right to report the patch here. If I'm wrong please tell me where to contribute.
Attachments (2)
Change History (7)
Changed 12 years ago by
Attachment: | CKEditorPlaceholderConfigurable.patch added |
---|
comment:1 Changed 12 years ago by
Status: | new → pending |
---|
I was convinced we had this issue reported. It turned out that we have something similar.
@ePex waht exactly do you mean by placeholder is not editable?
- Did you mean that when you click on it and then press toolbar button you don't get holder properties?
- Did you perhaps mean issue you may be getting in Firefox - http://dev.ckeditor.com/ticket/9505 ?
- Did you perhaps mean that editing placeholder doesn't work in Opera?
Could you describe what exactly is happening in editor in your case?
comment:2 Changed 12 years ago by
No, I said configurable, not editable ;) and by that I mean you can't define what your placeholder or placeholder-wrapper or whatever you want to call this is, I mean the double brackets that indicate the start and end of a placeholder. For example we use here [{text}] instead of and we can't change this because our whole framework expect that format. So what I did is basically add an option to configure/change the placeholder-indicator-whatever-thingy from the config.
comment:3 Changed 12 years ago by
@ePex Placeholder is not a "core plugin". It is not a part of the core and even it is not included by default in any of predefined presets. It's more a sample plugin to be extended by the developer.
Having said that, it does not mean that useful suggestions/improvements won't be accepted for it.
comment:4 Changed 12 years ago by
Keywords: | HasPatch removed |
---|---|
Status: | pending → confirmed |
And it sounds to me like a useful improvement.
@ePex To get your proposed fix/improvement tested and applied (if it is correct) please fork CKEditor 4 code from https://github.com/ckeditor/ckeditor-dev, prepare your fix and make a "pull request" (here is the example list of pull requests https://github.com/ckeditor/ckeditor-dev/pulls?direction=desc&page=1&sort=created&state=open). In comment please specify link to bug for which this fix was prepared. This is much faster way to get proposed fix/improvement implemented/rejected (if they are invalid). At least in V4.
comment:5 Changed 12 years ago by
Ok will do this as soon as possible. I don't have any time to do this because my desk is full of work but I'll do in a free minute (or two ;)).
Changed 11 years ago by
Attachment: | 10185.patch added |
---|
Added configuration option for placeholder plugin
CKEditorPlaceholderConfigurable.patch