Removing block style by editor.removeStyle should result in paragraph not div

[Piotrek Koszuliński]

1. Open replacebyclass sample.
2. Focus editor and place caret in the header (h1).
3. Paste this in the console: CKEDITOR.instances.editor1.removeStyle( new CKEDITOR.style( { element: 'h1' } ) );

• Expected result: h1 was removed, so "Apollo 11" should be a paragraph, because enterMode=P
• Actual: <div>Apollo 11</div>

This behaviour should be enterMode aware - in div mode it should transform element to <div>, in br mode it should remove it completely.

[Buzogany Laszlo]

I think the problem comes from the style.js where the this._.enterMode is not defined.

Doing this, resolve the problem:

this._ = {
  definition: styleDefinition,
  enterMode: CKEDITOR.config.enterMode
};

[Piotrek Koszuliński]

I replied for your pull request:

​https://github.com/ckeditor/ckeditor-dev/pull/33#issuecomment-14835366

Unfortunately your patch isn't correct, but now we at least know that style was aware of enter mode.

[Buzogany Laszlo]

Yes, you have right. There should be an other solution. For now and for me this was good, but your developpers will decide how to correclt handle this problem. Thanks for the help!

[Jakub Ś]

Problem can be reproduced in all browsers from CKEditor 4 beta.

[Marek Lewandowski]

Pushed to ​t/10190 at dev and t/10190 at tests.

[Piotrek Koszuliński]

I pushed rebased and corrected branches.

[Marek Lewandowski]

Fixed with ​git:c1cc4d2dc1 (merged to major) at dev and 0c6fc1b635 (merged to major) at tests.